Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor docs for EAEE #403

Merged
merged 7 commits into from
Apr 2, 2021
Merged

Refactor docs for EAEE #403

merged 7 commits into from
Apr 2, 2021

Conversation

aalu1418
Copy link
Contributor

@aalu1418 aalu1418 commented Mar 31, 2021

Updating README docs for various adapters for consistent layout and information structure

  • other small modifications for information/readability
  • applying template to composite adapters
  • applying template to adapters used in composite adapters

@github-actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@aalu1418
Copy link
Contributor Author

aalu1418 commented Mar 31, 2021

ToDo list for adapters:

  • json-rpc
  • dns-query
  • WBTC
  • RENVM
  • Amberdata
  • Blockchain.com
  • Blockcypher
  • Blockchair
  • BTC.com
  • CryptoAPIs
  • SoChain
  • CoinAPI
  • Coingecko
  • Coinmarketcap
  • Coinpaprika
  • Cryptocompare
  • Kaiko
  • Nomics

Lower Priority

  • XBTO
  • Genesis Volatility
  • DXFeed
  • Deribit
  • OilPriceAPI

@aalu1418 aalu1418 changed the title [WIP] Refactor docs for EAEE Refactor docs for EAEE Apr 1, 2021
@aalu1418 aalu1418 marked this pull request as ready for review April 1, 2021 20:17
Copy link
Contributor

@krebernisak krebernisak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @aalu1418! Looks great :)

For the next step on the topic of docs and API in general, we should think about exposing descriptive config & input/response info directly from the adapters, and potentially generate docs similar to this automatically. An adapter could expose
JSON data where everything is explained and which we can use to generate docs.

But, we should probably look to use already available tools, and for example, generate Swagger specification.

@krebernisak krebernisak merged commit 38c9496 into epic/EAEE Apr 2, 2021
@krebernisak krebernisak deleted the refactor/EAEE-adapter-docs branch April 2, 2021 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants