Proof of Reserves batch requests & burst limiting #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
HenryNguyen5
suggested changes
May 4, 2021
|
|
||
| const getBalanceURI = (address: string, confirmations: number) => | ||
| `/q/addressbalance/${address}?confirmations=${confirmations}` | ||
| const getBalanceURI = (addresses: string[]) => `balance?active=${addresses.join(',')}` |
There was a problem hiding this comment.
Suggested change
| const getBalanceURI = (addresses: string[]) => `balance?active=${addresses.join(',')}` | |
| const getBalanceURL = (addresses: string[]) => `balance?active=${addresses.join(',')}` |
Suggested change
| const getBalanceURI = (addresses: string[]) => `balance?active=${addresses.join(',')}` | |
| const getBalanceURI = (addresses: string[]) => `balance?active=${addresses.join(',')}` |
| * | ||
| * @returns 2d array | ||
| */ | ||
| export const chunk = (amount: number, data: any[]) => { |
There was a problem hiding this comment.
We should use rxjs for this
return from(data).pipe(bufferCount(amount), toArray())| * @returns array of response data | ||
| */ | ||
| export const throttle = async (amount: number, data: any[], exec: any) => { | ||
| const chunks = chunk(amount, data) |
There was a problem hiding this comment.
This can be expressed via rxjs
const output = from(data).pipe(
bufferCount(amount),
delay(1000),
mergeMap(
datas => forkJoin(datas.map(d =>exec(d)))
),
toArray()
).toPromise()
return output.flat()| } | ||
|
|
||
| const response = await Requester.request(reqConfig) | ||
| const response: any = await new Promise((resolve, reject) => |
There was a problem hiding this comment.
I would use https://nodejs.org/api/util.html#util_util_promisify_original here, or https://rxjs-dev.firebaseapp.com/api/index/function/bindNodeCallback
Comment on lines
+104
to
+106
| const requests = groups.flatMap((group) => { | ||
| return getBalances(group as Account[], config) | ||
| }) |
There was a problem hiding this comment.
How do you feel about one-lining this?
Suggested change
| const requests = groups.flatMap((group) => { | |
| return getBalances(group as Account[], config) | |
| }) | |
| const requests = groups.flatMap((group) => | |
| getBalances(group as Account[], config) | |
| ) |
Suggested change
| const requests = groups.flatMap((group) => { | |
| return getBalances(group as Account[], config) | |
| }) | |
| const requests = groups.flatMap((group) => { | |
| return getBalances(group as Account[], config) | |
| }) |
| api.getAddrBal(account.address, params, (error: Error, body: AddressBalance) => | ||
| error ? reject(error) : resolve(body), | ||
|
|
||
| const _getAddrBal = (addrs: string[]) => |
There was a problem hiding this comment.
Underscores mean unused in JS-land (by linters and tsc too), we shouldnt be using it as an internal function naming convention. Best to keep regular camel casing.
| ? await util.throttle(config.ratelimit, addresses, _getAddrBal) | ||
| : await _getAddrBal(addresses) | ||
|
|
||
| const addrLookup: { [key: string]: AddressBalance } = {} |
There was a problem hiding this comment.
Suggested change
| const addrLookup: { [key: string]: AddressBalance } = {} | |
| const addrLookup: Record<string,AddressBalance> = {} |
Suggested change
| const addrLookup: { [key: string]: AddressBalance } = {} | |
| const addrLookup: { [key: string]: AddressBalance } = {} |
| const api = new bcypher(account.coin, chainId, config.apiKey) | ||
| const getBalances: balance.GetBalances<Config> = async (accounts, config) => { | ||
| const addresses = accounts.map((a) => a.address) | ||
| const { coin, chain } = accounts[0] |
There was a problem hiding this comment.
Is it always the same coin/chain for all accounts? We should note that if so
| export const makeConfig = (prefix = ''): Config => { | ||
| const config = Requester.getDefaultConfig(prefix) | ||
| const ratelimit = util.getEnv(ENV_RATE_LIMIT, prefix) | ||
| if (ratelimit) config.ratelimit = Number(ratelimit) |
There was a problem hiding this comment.
Suggested change
| if (ratelimit) config.ratelimit = Number(ratelimit) | |
| config.ratelimit &&= Number(ratelimit) |
Suggested change
| if (ratelimit) config.ratelimit = Number(ratelimit) | |
| if (ratelimit) config.ratelimit = Number(ratelimit) |
|
Closing. This PR is very outdated. The burst limiter middle-ware and batch warmer have made this change obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaying the previous #276 as a hotfix PR into master due to priority.
This will need to be engineered into an actual burst rate limit feature on EAEE.
Next steps:
API_RATE_LIMITwill need to be added to Blockcypher's environment variables.API_KEYandAPI_SECRETneed to be added for BTC.comBLOCKCYPHER_API_RATE_LIMITwill need to be added to blockcypher PoR adapterBTC_COM_API_SECRETandBTC_COM_API_KEYwill need to be added to BTC.com PoR adapterStory
https://app.clubhouse.io/chainlinklabs/story/7356/wbtc-por-adapter-fix