Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fixed price feature to the PriceOracle contract #26

Merged
merged 6 commits into from
May 16, 2024
Merged

Add fixed price feature to the PriceOracle contract #26

merged 6 commits into from
May 16, 2024

Conversation

amit-momin
Copy link
Collaborator

  • Adds a feature to the PriceOracle contract to allow it to serve a fixed price for an asset
  • This feature is expected to be used for assets deprecated by Compound that no longer have a price feed
  • It will allow the PriceOracle contract to support FEI, REP, and SAI. The prices for these are set to what is returned by the existing UAV. Since the price feeds no longer exist for these assets, the price in the UAV is essentially fixed.
  • This update adds support for the deprecated WBTC asset but sets the config to use the same price feed as WBTCv2

@amit-momin amit-momin marked this pull request as ready for review May 13, 2024 18:57
@amit-momin amit-momin requested a review from cds95 May 13, 2024 18:57
@amit-momin amit-momin requested a deployment to ci May 13, 2024 19:24 — with GitHub Actions Abandoned
@amit-momin amit-momin requested a deployment to ci May 13, 2024 19:24 — with GitHub Actions Abandoned
@amit-momin amit-momin requested a deployment to ci May 13, 2024 19:24 — with GitHub Actions Abandoned
cds95
cds95 reviewed May 14, 2024
View reviewed changes
contracts/PriceOracle/PriceOracle.sol Outdated Show resolved Hide resolved
contracts/PriceOracle/PriceOracle.sol Outdated Show resolved Hide resolved
contracts/PriceOracle/PriceOracle.sol Show resolved Hide resolved
contracts/PriceOracle/PriceOracle.sol Outdated Show resolved Hide resolved
@amit-momin amit-momin merged commit cdbb137 into master May 16, 2024
2 of 3 checks passed
@amit-momin amit-momin deleted the feature/fixed-price-for-deprecated-markets branch May 16, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cds95 cds95 cds95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@amit-momin @cds95