-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a generic read_csv method #147
Conversation
Codecov Report
@@ Coverage Diff @@
## development #147 +/- ##
===============================================
+ Coverage 83.90% 84.26% +0.36%
===============================================
Files 81 84 +3
Lines 8724 8989 +265
===============================================
+ Hits 7320 7575 +255
- Misses 1404 1414 +10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
b354ae3
to
9310790
Compare
hey. Thanks again for contributing. Some notes:
"Example" part is important as code snippets are also compiled and used as tests.
Great work, especially with the test coverage and error handling 💯 |
Hi @Mec-iS ! |
5591bff
to
23e826f
Compare
To construct a `Matrix` from csv, and therefore from string, I need to be able to deserialize a generic `RealNumber` from string.
6c8e5e8
to
ddfa5f0
Compare
|
* feat: Add interface to build `Matrix` from rows. * feat: Add option to derive `RealNumber` from string. To construct a `Matrix` from csv, and therefore from string, I need to be able to deserialize a generic `RealNumber` from string. * feat: Implement `Matrix::read_csv`.
Looking into implementing #66.