Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PLAY_PAUSE to ButtonName enum #228

Closed
justinjdickow opened this issue Jun 29, 2015 · 3 comments
Closed

Add PLAY_PAUSE to ButtonName enum #228

justinjdickow opened this issue Jun 29, 2015 · 3 comments
Assignees
Projects

Comments

@justinjdickow
Copy link
Contributor

No description provided.

@justinjdickow justinjdickow added this to the 4.1.0 milestone Jun 29, 2015
joeygrover added a commit that referenced this issue Jun 30, 2015
@kshala-ford
Copy link
Contributor

@joeygrover any update to the PLAY_PAUSE feature? Anyhting that need to be done beforehand?

@joeygrover
Copy link
Member

Hi @kshala-ford,

In the future, please try not to post questions about a global SDL feature in multiple repos, this would be better as a question in Slack.

The PLAY_PAUSE enum needs to be added to the RPC spec at an agreed upon version. Due to old systems using OK as the PLAY_PAUSE functionality, we need to ensure that when developers subscribe to only PLAY_PAUSE that on older systems the library can subscribe them to OK. Then when an OK is received, translate it to a PLAY_PAUSE. It would be best added once the SDLC has a proper versioning system in place for the RPC spec. The roadmap has this versioning process in place this quarter.

@BrettyWhite
Copy link
Contributor

Closed with #864

@BrettyWhite BrettyWhite added this to Done in 4.7.0 Sep 26, 2018
@jordynmackool jordynmackool removed this from the 4.1.0 milestone Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
4.7.0
  
Done
Development

No branches or pull requests

5 participants