Check for BT Permission in SdlRouterService.onCreate() #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
askirk
commented
Jan 25, 2017
•
askirk
commented
- To resolve issue Process does not have BLUETOOTH permission: java.lang.SecurityException #376
- this may contribute to NPE in SdlRouterService.bluetoothAvailable() : BluetoothAdapter.getDefaultAdapter().isEnabled() call #378
- We just stop the service if permission isn't there, any further handling will be done at a future time
Checking in onCreate()
joeygrover
reviewed
Feb 7, 2017
| @@ -53,6 +54,7 @@ | |||
| import android.os.Parcel; | |||
| import android.os.Parcelable; | |||
| import android.os.RemoteException; | |||
| import android.support.v4.content.ContextCompat; | |||
There was a problem hiding this comment.
We don't want to use any of the support libraries. That would force our developers to use the same support library. I suggest trying to use the normal context method if android version is 23+, or fully qualified contextcompat with a try catch
joeygrover
reviewed
Feb 7, 2017
| @@ -783,6 +785,11 @@ public void onCreate() { | |||
| stopSelf(); | |||
There was a problem hiding this comment.
This section is getting a bit large and should be moved to a single function with a name like initCheck() that returns a boolean if the checks passed.
-Still need to find a way to use ContextCompat without importing support library
joeygrover
reviewed
Feb 7, 2017
build.gradle
Outdated
| @@ -13,7 +13,7 @@ dependencies { | |||
| } | |||
|
|
|||
| android { | |||
| compileSdkVersion 18 | |||
| compileSdkVersion 23 | |||
There was a problem hiding this comment.
We can't up the compile version with approval from the SDLC
joeygrover
reviewed
Feb 9, 2017
| @@ -851,6 +875,8 @@ public void startUpSequence(){ | |||
|
|
|||
| @Override | |||
| public int onStartCommand(Intent intent, int flags, int startId) { | |||
| if(!initPassed) | |||
There was a problem hiding this comment.
Please include brackets around this if statement
Brackets around IF
joeygrover
approved these changes
Feb 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.