Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move app launcher stop before unregister app. #2444

Closed
HSavynetska opened this issue Jul 30, 2018 · 4 comments · Fixed by #3825
Closed

Move app launcher stop before unregister app. #2444

HSavynetska opened this issue Jul 30, 2018 · 4 comments · Fixed by #3825
Assignees
Projects

Comments

@HSavynetska
Copy link

Bug Report

Move app launcher stop before unregister app.

Descriptions:

The applauncher has to be stopped before appropriate application
will be unregistered. Otherwise it could lead to core crash, when
Launch controller will try to run already non existed application

OS & Version Information
  • OS/Version:
  • SDL Core Version:
  • Testing Against:
@ZhdanovP
Copy link
Contributor

This situation is fair for case when SDL is stopping and all application unregistered, now applauncher don't stop clearly, it stops only after the object is destroyed. We have added apparent stop the applauncher before the application unregistered. Since this happens during SDL is stopping we can't make atf script for testing this issue.

@theresalech
Copy link
Contributor

@dboltovskyi, can you please advise when merge conflicts for PR #2535 have been resolved and the PR is ready for Livio's review?

@dboltovskyi
Copy link
Contributor

@theresalech Please notice initial fix for this issue in #2535 is pretty old. We're updating and re-testing it now. Our plan is to re-submit new version in a couple of days.

@theresalech theresalech added this to Bug Fixes in 8.1.0 Dec 16, 2021
@jacobkeeler jacobkeeler linked a pull request Dec 23, 2021 that will close this issue
1 task
@jacobkeeler
Copy link
Contributor

Closed via #3825

@theresalech theresalech moved this from Bug Fixes to Completed Bug Fixes/ Enhancements in 8.1.0 Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
8.1.0
Completed Bug Fixes/ Enhancements
Development

Successfully merging a pull request may close this issue.

7 participants