Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unauthorized app does not get unregistered. #2795

Closed
Nilesh-harman opened this issue Jan 8, 2019 · 2 comments
Closed

Unauthorized app does not get unregistered. #2795

Nilesh-harman opened this issue Jan 8, 2019 · 2 comments
Labels
Projects

Comments

@Nilesh-harman
Copy link

Hi,
We need help related to wrong app-id passed to SyncProxyTester app. It's an app revoked issue i.e. unauthorized app handling.
There is no implementation for unregistering the unauthorized app in this scenario.

Pre-conditions:

  1. Vehicle ignition is ON
  2. CTR is ON
  3. Android device connected via BT

Error Path:

  1. Set APP ID 2110975391 with SyncProxyTester
  2. Try to select SyncProxyTester on SYNC.
  3. HMI shows UserFriendlyMessage.

Observed behavior:
SyncProxyTester does not get unregister from HMI.

Expected behavior:
As per SDL integration guideline(#3.1.2) the app should unregister as "isAppRevoked: true"
From the sequence diagram#13.1.4.5, please refer the rpc flow below
1)HMI-->SDL: request of SDL.ActivateApp
2)SDL-->HMI: response of SDL.ActivateApp with "isAppRevoked: true"
3)SDL-->HMI: Notification of BasicCommunication.OnAppUnregistered
But there is no implementation for OnAppUnregistered for the step #3.

Note: Version used is SDL 4.2. Please let me know if you need any info.

Thanks.

@AKalinich-Luxoft
Copy link
Contributor

@Nilesh-harman we think that SDL behavior is correct in this case. It should not unregister the application, but should not allow to activate it after that. We also have ATF scripts with the corresponding expectations.

Additionally, SDL core has a field "count_of_run_attempts_while_revoked" (and ATF script) in the statistics section of the policy table which is used to track the attempts of activation of the revoked app, which makes no sense if SDL will unregister revoked applications.

For that reason, we concluded that the SDL integration guideline itself is wrong and should be updated to reflect the proper core behavior.
See the following PRs with the changes:
smartdevicelink/sdl_atf_test_scripts#2606
smartdevicelink/sdl_hmi#634
smartdevicelink/generic_hmi#475
smartdevicelink/sdl_hmi_integration_guidelines#259

@iCollin
Copy link
Collaborator

iCollin commented Feb 11, 2022

Closed via the above PRs

@iCollin iCollin closed this as completed Feb 11, 2022
@theresalech theresalech added this to Features in 8.1.0 via automation Feb 14, 2022
@theresalech theresalech moved this from Features to Completed Bug Fixes/ Enhancements in 8.1.0 Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
8.1.0
Completed Bug Fixes/ Enhancements
Development

No branches or pull requests

4 participants