Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apps cannot be registered if MaxSupportedProtocolVersion is set to 1 #3818

Closed
jacobkeeler opened this issue Nov 5, 2021 · 1 comment
Closed
Projects

Comments

@jacobkeeler
Copy link
Contributor

Bug Report

If MaxSupportedProtocolVersion=1 is set in the INI file, no apps are allowed to register. This is because Core returns UNSUPPORTED_VERSION to protocol v1 apps.

Minimum value for MaxSupportedProtocolVersion should be changed to 2, since Core does not support protocol v1.

Reproduction Steps
  1. Set MaxSupportedProtocolVersion=1 in smartDeviceLink.ini
  2. Start Core
  3. Register App
Expected Behavior

App registers

Observed Behavior

App does not register

OS & Version Information
  • OS/Version: Ubuntu 20.04
  • SDL Core Version: master
  • Testing Against: RPC Builder JS
@jacobkeeler jacobkeeler added this to Features in 8.1.0 via automation Nov 5, 2021
@jacobkeeler
Copy link
Contributor Author

Closed via #3801

8.1.0 automation moved this from Features to Completed Features Nov 5, 2021
@jacobkeeler jacobkeeler moved this from Completed Features to Completed Bug Fixes/ Enhancements in 8.1.0 Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
8.1.0
Completed Bug Fixes/ Enhancements
Development

No branches or pull requests

2 participants