You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The timestamp and last_ign_off_time parameters in the resumption data storage are currently written to and read as uint32_t, which could be shorter than time_t. These parameters should be stored as int64_t to prevent narrowing conversions. See here
Reproduction Steps
Set clock so that the timestamp goes past the unsigned 32 bit limit (year=2200 should work)
Start Core
Connect app
Stop Core and check app_info.dat
Expected Behavior
timestamp should match up with system clock
Observed Behavior
timestamp does not match up with system clock due to narrowing conversion
OS & Version Information
OS/Version: Ubuntu 20.04
SDL Core Version: master
The text was updated successfully, but these errors were encountered:
Bug Report
Detected by Coverity (CIDs 277332 and 277353).
The
timestamp
andlast_ign_off_time
parameters in the resumption data storage are currently written to and read asuint32_t
, which could be shorter thantime_t
. These parameters should be stored asint64_t
to prevent narrowing conversions. See hereReproduction Steps
app_info.dat
Expected Behavior
timestamp
should match up with system clockObserved Behavior
timestamp
does not match up with system clock due to narrowing conversionOS & Version Information
The text was updated successfully, but these errors were encountered: