Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDLChoiceSetManager does not remove InteractionChoiceSet (ID: 0) after sdl_sendTestChoices #1129

Closed
t-yoshii opened this issue Nov 15, 2018 · 1 comment
Assignees
Labels
bug A defect in the library
Projects
Milestone

Comments

@t-yoshii
Copy link

Bug Report

SDLChoiceSetManager does not remove InteractionChoiceSet (ID: 0) after sdl_sendTestChoices.

SDLChoiceSetManager creates following choice set and does not delete it.
https://github.com/smartdevicelink/sdl_ios/blob/master/SmartDeviceLink/SDLCheckChoiceVROptionalOperation.m#L73

Reproduction Steps
  1. Connect SDL iOS app using SDL manager
  2. Send CreateInteractionChoiceSet with id 0
  3. Send PerformInteraction with ChoiceSet id 0
Expected Behavior
  1. RPC succeed.
  2. User see the choices list which are sent at Step 2.
Observed Behavior
  1. RPC fails with "INVALID_ID" because ID:0 is already used.
  2. User see unexpected list "Test cell" and "Test VR".
OS & Version Information
  • iOS Version: iOS11, 12
  • SDL iOS Version: 6.1.1
  • Testing Against: Our intenal devboard. Ford SYNC devboard
Test Case, Sample Code, and / or Example App

https://github.com/smartdevicelink/sdl_ios/blob/master/SmartDeviceLink/SDLCheckChoiceVROptionalOperation.m#L73

@joeljfischer joeljfischer added this to the 6.2.0 milestone Nov 28, 2018
@joeljfischer
Copy link
Contributor

Generally, you should not mix using a manager with using the RPC directly, so this bug is minor. However, we will fix it for the next minor release.

@joeljfischer joeljfischer added the bug A defect in the library label Nov 28, 2018
@joeljfischer joeljfischer self-assigned this Nov 28, 2018
@joeljfischer joeljfischer added this to Done in v6.2.0 via automation Nov 30, 2018
@joeljfischer joeljfischer mentioned this issue Apr 1, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library
Projects
No open projects
v6.2.0
  
Done
Development

No branches or pull requests

2 participants