First StartService isn't always V1

[kshala-ford]

Bug Report

Upon iAP connect, the SDL library should always send a V1 StartService request for RPC service. However on subsequent iAP connects, the library sends a V2. This this isn't a big issue as long as the same car is used. Also with V1 being basically obsolete it's a low priority bug, however the behavior is incorrect according to the protocol spec, that's why I created the issue. If we would ever create a V3 frame type this issue would become critical for multi car use cases (like families share two cars).

Reproduction Steps

1. Install Hello SDL
2. Connect to any SDL system and track first StartService request
3. Disconnect from the SDL system
4. Reconnect to the SDL system and track first StartService request

Expected Behavior

Both requests should be V1 frames like

TX: 10070100 00000020          200000000270726F746F636F6C56657273696F6E0006000000352E332E300000

Observed Behavior

The first request is a V1 frame like expected. The second however is a V2 frame.

TX: 30070100 00000020 00000000 200000000270726F746F636F6C56657273696F6E0006000000352E332E300000

OS & Version Information

• iOS Version: Any
• SDL iOS Version: 7.0.0 RC3 (also visible in previous versions)
• Testing Against: SDL Example, Ford SYNC3 test bench

Comment

In this code https://github.com/smartdevicelink/sdl_ios/blob/7.0.0-rc.3/SmartDeviceLink/private/SDLProtocol.m#L508 the library sets the maximum head unit protocol version. The SDLGlobal class overwrites the protocol version (see https://github.com/smartdevicelink/sdl_ios/blob/7.0.0-rc.3/SmartDeviceLink/private/SDLGlobals.m#L84). The issue is that the library doesn't reset the version objects on disconnect.

A simple reset on disconnect should solve the problem.