Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Manager will upload the same file multiple times #2034

Closed
joeljfischer opened this issue Sep 13, 2021 · 0 comments · Fixed by #2040
Closed

File Manager will upload the same file multiple times #2034

joeljfischer opened this issue Sep 13, 2021 · 0 comments · Fixed by #2040
Labels
bug A defect in the library manager-file Relating to the manager layer - file
Projects

Comments

@joeljfischer
Copy link
Contributor

Bug Report

When trying to load multiple of the same artwork and the file is not uploaded yet, the file will be uploaded multiple times. This is because we create multiple of the same upload operation and they all execute.

We should probably implement the upload / delete operation to check if the file needs to be uploaded at the time it would run instead of the manager figuring out if the operation should be created at all.

Reproduction Steps
  1. Create 99 SDLArtworks that are exactly the same
  2. Attempt to upload all 99 in a loop
Expected Behavior

The one artwork will be uploaded 99 times, slowing down the head unit like crazy.

Observed Behavior

The one artwork should only be uploaded 1 time.

OS & Version Information
  • iOS Version: [What version of iOS are you using when the bug occurred]
  • SDL iOS Version: [What version of the library has this bug been seen on]
  • Testing Against: [What you tested with to observe this behavior]
Test Case, Sample Code, and / or Example App

[Paste a link to a PR, gist, or other code that exemplifies this behavior]

@joeljfischer joeljfischer added bug A defect in the library manager-file Relating to the manager layer - file labels Sep 13, 2021
@joeljfischer joeljfischer added this to To do in v7.3.0 via automation Sep 27, 2021
@joeljfischer joeljfischer moved this from To do to Done in v7.3.0 Sep 27, 2021
@joeljfischer joeljfischer mentioned this issue Sep 27, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library manager-file Relating to the manager layer - file
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant