Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock Screen Race Conditions #2063

Closed
joeljfischer opened this issue Oct 29, 2021 · 0 comments · Fixed by #2066
Closed

Lock Screen Race Conditions #2063

joeljfischer opened this issue Oct 29, 2021 · 0 comments · Fixed by #2066
Assignees
@joeljfischer
Labels
bug A defect in the library manager-lockscreen Relating to the manager layer - lockscreen
Projects
v7.4.0

Comments

@joeljfischer
Copy link
Contributor

Bug Report

The SDLLockScreenStatusManager is owned by the SDLLockScreenManager but gets its driver distraction notifications from its own registrations. This creates a race condition with the driver distraction notification usage that the SDLLockScreenManager uses. This causes some strange behavior with dismissibility. We should refactor the lock screen manager / status manager to have the LSM pass to the status manager the new DD notification or HMI status notification and do something with the result.
@joeljfischer joeljfischer added bug A defect in the library manager-lockscreen Relating to the manager layer - lockscreen labels Oct 29, 2021
@joeljfischer joeljfischer added this to To do in v7.4.0 via automation Oct 29, 2021
@joeljfischer joeljfischer mentioned this issue Jan 4, 2022
Merged
4 tasks
@joeljfischer joeljfischer self-assigned this Jan 4, 2022
@joeljfischer joeljfischer linked a pull request Jan 4, 2022 that will close this issue
Fix potential lock screen race condition #2066
Merged
4 tasks
v7.4.0 automation moved this from To do to Done Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joeljfischer joeljfischer

Labels
bug A defect in the library manager-lockscreen Relating to the manager layer - lockscreen
Projects
No open projects
v7.4.0
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix potential lock screen race condition smartdevicelink/sdl_ios
1 participant
@joeljfischer