Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning logs when removing invalid voice commands #2075

Closed
joeljfischer opened this issue Mar 30, 2022 · 0 comments
Closed

Add warning logs when removing invalid voice commands #2075

joeljfischer opened this issue Mar 30, 2022 · 0 comments
Labels
best practice Not a defect but something that should be improved anyway manager-screen Relating to the manager layer - screen managers
Projects
v7.4.0

Comments

@joeljfischer
Copy link
Contributor

Bug Summary

We currently do not notify the developer about invalid voice commands that are automatically removed. We should add those logs.

See Java Suite PR: smartdevicelink/sdl_java_suite#1799

Reproduction Steps

  1. Create a voice command without any strings
  2. Set voice command

Expected Behavior:
A warning log that the voice command is removed and why is displayed

Observed Behavior:
The voice command is removed with no log for the developer

iOS Version(s)

No response

sdl_ios Version

7.3.2-develop

Testing Environment(s)

n/a - Any

Relevant log output

No response
@joeljfischer joeljfischer added bug A defect in the library needs triage An issue that has not yet been triaged manager-screen Relating to the manager layer - screen managers and removed needs triage An issue that has not yet been triaged labels Mar 30, 2022
@joeljfischer joeljfischer added this to To do in v7.4.0 via automation Mar 30, 2022
@joeljfischer joeljfischer mentioned this issue Mar 30, 2022
Merged
4 tasks
v7.4.0 automation moved this from To do to Done Mar 30, 2022
@FrankElias77 FrankElias77 added best practice Not a defect but something that should be improved anyway and removed bug A defect in the library labels Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
best practice Not a defect but something that should be improved anyway manager-screen Relating to the manager layer - screen managers
Projects
No open projects
v7.4.0
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joeljfischer @FrankElias77