-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streaming sessions are not closed on proxy disconnect #386
Comments
How do you mean disconnect? If only the RPC service disconnects that does not affect the video or audio services. |
Shouldn't we be checking the connection state of the proxy before sending data of any kind? This may actually be even further out of scope and be a question for the entirety of the proxy. If we start a video session, and core is shut down, what happens to this session? Is the |
When a transport is disconnected, it ought to notify the proxy, which ought to notify its protocol that all sessions have been terminated, which should then roll back up the chain to the streaming manager. That's how I think it should work, but I doubt it does work that way. |
@asm09fsu Has this been fixed? |
@joeljfischer This has not been resolved, however with the improvements in this proposal it would be resolved. We could add a hot fix in now that would notify SMM of these changes. |
@asm09fsu That would be better. We don't want to wait 'till 5.0 for bug fix changes if possible. |
Bug Report
Currently, if a video or audio streaming session in
SDLStreamingMediaManager
is connected and streaming, and the proxy gets disconnected, the streams are in a non-ideal state as they are not closed.Reproduction Steps
Expected Behavior
Video/audio streaming should be stopped.
Observed Behavior
Video/audio streaming is not stopped.
OS & Version Information
The text was updated successfully, but these errors were encountered: