Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix SDLTouchManager to handle all touch events in SDLOnTouchEvent #935

Merged
merged 1 commit into from
Apr 25, 2018
Merged

fix SDLTouchManager to handle all touch events in SDLOnTouchEvent #935

merged 1 commit into from
Apr 25, 2018

Conversation

t-yoshii
Copy link

Fixes #934

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

Unit test is also updated.

Summary

Fix SDLTouchManager to handle all touch events in SDLOnTouchEvent.

Changelog

Bug Fixes
  • fix SDLTouchManager to handle all touch events in SDLOnTouchEvent

CLA

@joeljfischer joeljfischer self-requested a review April 19, 2018 14:03
@joeljfischer joeljfischer added the bug A defect in the library label Apr 19, 2018
@joeljfischer joeljfischer added this to the 6.0.0 milestone Apr 19, 2018
@NicoleYarroch NicoleYarroch requested review from NicoleYarroch and removed request for joeljfischer April 25, 2018 12:25
@joeljfischer joeljfischer merged commit f251906 into smartdevicelink:develop Apr 25, 2018
@t-yoshii t-yoshii mentioned this pull request May 14, 2018
Closed
@joeljfischer joeljfischer mentioned this pull request May 14, 2018
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicoleYarroch NicoleYarroch NicoleYarroch approved these changes

Assignees

@t-yoshii t-yoshii

Labels
bug A defect in the library
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@t-yoshii @NicoleYarroch @joeljfischer