Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDL 0282] Screen Manager Alert Manager #1304

Closed
theresalech opened this issue Mar 9, 2020 · 2 comments
Closed

[SDL 0282] Screen Manager Alert Manager #1304

theresalech opened this issue Mar 9, 2020 · 2 comments
Labels
manager-screen Relating to the manager layer - screen managers proposal Accepted SDL Evolution Proposal
Projects
5.1.0

Comments

@theresalech
Copy link
Contributor

Proposal: Screen Manager Alert Manager

This proposal adds alert management (based on the Alert RPC) to the screen manager API.

Review: smartdevicelink/sdl_evolution#948

Steering Committee Decision:

The Steering Committee voted to accept this proposal with the following revisions:

  • Use a builder pattern as described in this comment.
  • Change SDLAlertAudioData to be a subclass of SDLAudioData.
  • Change the audio data property and initializer to take an array to allow for multiple pieces of audio data.
  • Clarify "if the error value is present, then the alert failed to appear or the user aborted it, if not, then the alert dismissed without error." within the inline documentation for presentAlert.

The proposal .md file was updated to reflect these revisions on 3/9/2020.
@theresalech theresalech mentioned this issue Mar 9, 2020
Closed
@theresalech theresalech added the proposal Accepted SDL Evolution Proposal label Mar 9, 2020
@joeljfischer joeljfischer added the manager-screen Relating to the manager layer - screen managers label May 7, 2020
@JulianKast JulianKast mentioned this issue Nov 9, 2020
Merged
16 tasks
@jordynmackool jordynmackool added this to Bugs in 5.1.0 via automation Dec 10, 2020
@jordynmackool jordynmackool moved this from Bugs to Features in 5.1.0 Dec 10, 2020
@jordynmackool jordynmackool moved this from Features to To Do in 5.1.0 Dec 10, 2020
@jordynmackool
Copy link
Contributor

The proposal markdown file has been updated per the revisions included in the accepted Revise SDL-0282 Screen Manager Alert Manager.

Accepted revisions can be reviewed in the merged PR here: smartdevicelink/sdl_evolution#1111.

@jordynmackool jordynmackool mentioned this issue Feb 3, 2021
Closed
@jordynmackool jordynmackool moved this from To Do to Review In Progress in 5.1.0 Mar 3, 2021
@JulianKast
Copy link
Contributor

Implemented in #1555

5.1.0 automation moved this from Review In Progress to Done Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
manager-screen Relating to the manager layer - screen managers proposal Accepted SDL Evolution Proposal
Projects
No open projects
5.1.0
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@joeljfischer @JulianKast @theresalech @jordynmackool