-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting devices with SDL 2.0.0 #1541
Comments
@peterkomar Thanks for reporting the issue. We fixed that bug in a hotfix release (v4.12.2) for the previous major version. We also included that fix in |
@bilal-alsharifi issue with MediaTrackTextField was fixed, thanks. |
@peterkomar Thanks for testing the fixes. Can you elaborate more on the permission issue? do you mean the policy table updates don't work? Would it be possible to provide the exact reproductions steps for that issue, the expected behavior, and what is the wrong behavior that you are seeing? |
It's stuck in this state. I see some network traffic on my device from my app when retrieving permissions just starts, after that, I didn't see any network traffic until retrieving permissions didn't restart again. On the older version of Android SDL 4.9.0 it was able to successfully finish. But the interesting thing I noticed on the older version (4.12.1 before the fix, also in 4.9.0) of Android SDL I was able to retrieve all vehicle data except tire pressure, it returned "Requested Vehicle Data is not available" but after the fix which you applied now I able to retrieve tire pressure as well. But I'm not totally sure if it related. |
I retested with our Sync 2.0 TDK through the automatic process and the manual process. In both scenarios it appears to complete successfully. Please note that downloading the policy table and sending it to the module doesn't take very much time, however, the TDK takes around ~30 seconds to update the policy table on its end. At this point I don't believe there is much we can do on the library side to determine what is happening in your situation. I would recommend doing a factory reset of the module in case maybe the policy table became corrupt and it's unable to apply the update. See video of the manual process attached. |
@joeygrover Thanks for checking 👍 |
@joeygrover just tried again after a factory reset but the problem still the same. I waiting for 2 mins. But when I run this app https://github.com/smartdevicelink/rpc_builder_app_android/releases lastest version I'm using this release https://github.com/smartdevicelink/rpc_builder_app_android/releases/download/1.4.0/RPCBuilder.apk with my app name and appid permissions were downloaded sucessfuly. My device is Sync 1.1 get 2 with software 5.11 and SDL 2.0.0 What version of Sync contains your TDK? |
Just noticed that I'm using sdl sdk 5.0.0 instead of 4.12.2. Sorry, my fault :( |
So, just to double check, does that mean everything is working on your end now with 4.12.2? |
I will give an answer later this week when I will have access to the vehicle. |
Confirming that download permissions work with 4.12.2 on SDL 2.0 (I did a factory reset before the test ) but found the other issue: I the head unit I have only one checkbox
But when I make a request I'm able to retrieve the odometer and vin only. Other data is not available (received response: vehicle data vas not available). When I download permissions with sdl_java_suite 4.9.0 I'm able to retrieve all these data. Could you check if data is available on your Sync 2.0 TDK after download permissions? Also found when I check permissions with
it always returns false for all of them but actually, I'm able to get some of the data. when I call for example:
I'm able to get the odometer but android Here some logs from my app, hope it will help |
I have confirmed that the policy table update occurs correctly with our unit. I was able to grant user consent when activating an app that requested vehicle data. After this consent, the app received an OnPermissionChange that contained the correct state of permissions. The permission manager then returns true for the following: PermissionManager permissionManager = sdlManager.getPermissionManager();
Boolean bodyInfoAllowed = permissionManager.isPermissionParameterAllowed(FunctionID.GET_VEHICLE_DATA, GetVehicleData.KEY_BODY_INFORMATION);
Log.d(TAG, "Body info allowed: " + bodyInfoAllowed); The app is then able to retrieve the body information successfully. My only suggestion would be to make sure you are using the correct app name and app ID that was provided to Ford for access. At this point I'm really not sure how much more we are going to be able to help find the issue. This might be a better time to talk directly with your Ford contact. Of course we will assist if we can, but I don't see where the library would be at fault at this point. |
Thanks for checking. |
Bug Report
I'm using an old device with SDL 2.0 and I don't have the ability to upgrade to the latest. Looks like the last versions of android SDL doesn't support old SDL cores.
Reproduction Steps
MediaTrackTextField
it doesn't work with 4.12.x versions but work with 4.9.0 versionOS & Version Information
The text was updated successfully, but these errors were encountered: