Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing permission check in IntegrationValidator #1615

Closed
joeygrover opened this issue Feb 4, 2021 · 0 comments
Closed

Missing permission check in IntegrationValidator #1615

joeygrover opened this issue Feb 4, 2021 · 0 comments
Assignees
Labels
bug A defect in the library
Projects

Comments

@joeygrover
Copy link
Member

Bug Report

The IntegrationValidator checks for a correct implementation, however as of Android 11 a new permission, android.permission.QUERY_ALL_PACKAGES, had to be added in order for the SDL library to work. The validator still throws an error when this permission is not included but only because one of the other checks requires that permission. The error message given to the developer is then misleading stating that the SdlBroadcastReceiver is not implemented correctly when in fact it is, but without the new permission the IntegrationValidator can't query for the receiver.

Reproduction Steps
  1. Deploy sample app on Android 11 device without android.permission.QUERY_ALL_PACKAGES permission
  2. Attempt to start app
  3. Notice error in logcat stating incorrect reasoning for determining an incorrect implementation
Expected Behavior

Validator provides meaningful and correct information when informing developers what is missing or wrong with their integration. In this case states the developer is missing the android.permission.QUERY_ALL_PACKAGES permission.

Observed Behavior

The IntegrationValidator tells the developer their SdlBroadcastReceover is incorrectly implimented.

OS & Version Information
  • Android Version: 11, will not occur on older versions
  • SDL Android Version: 5.0.0
@joeygrover joeygrover self-assigned this Feb 4, 2021
@joeygrover joeygrover added this to Contributions in 5.1.0 via automation Feb 4, 2021
@joeygrover joeygrover moved this from Contributions to In Progress in 5.1.0 Feb 4, 2021
@jordynmackool jordynmackool added the bug A defect in the library label Feb 4, 2021
5.1.0 automation moved this from In Progress to Done Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library
Projects
No open projects
5.1.0
Done
Development

No branches or pull requests

3 participants