Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@deprecated annotation in class Javadoc makes the whole class marked as deprecated #1626

Closed
bilal-alsharifi opened this issue Mar 5, 2021 · 0 comments
Closed

@deprecated annotation in class Javadoc makes the whole class marked as deprecated #1626

bilal-alsharifi opened this issue Mar 5, 2021 · 0 comments
Labels
android Relating to the android part of the library bug A defect in the library cloud Relating to Java-SE / Java-EE Cloud Apps
Projects
5.1.0

Comments

@bilal-alsharifi
Copy link
Contributor

Bug Report

We noticed that if a class Javadoc has the @deprecated keyword to deprecate one of the class properties, Android Studio mistakenly marks the whole class as deprecated.
For example, because externalTemperature is deprecated, Android Studio thinks that GetVehicleData is deprecated which is not correct.

sdl_java_suite/base/src/main/java/com/smartdevicelink/proxy/rpc/GetVehicleData.java

Line 116 in 1118f39

* @deprecated in SmartDeviceLink 7.1.0

That should be fixed by using something like@property-deprecated instead of @deprecated in the class Javadoc

OS & Version Information
  • SDL Android Version: 5.0
@bilal-alsharifi bilal-alsharifi added bug A defect in the library android Relating to the android part of the library cloud Relating to Java-SE / Java-EE Cloud Apps labels Mar 5, 2021
@bilal-alsharifi bilal-alsharifi added this to Contributions in 5.1.0 via automation Mar 5, 2021
@bilal-alsharifi bilal-alsharifi mentioned this issue Mar 5, 2021
Merged
1 task
@joeljfischer joeljfischer moved this from Contributions to Review In Progress in 5.1.0 Mar 9, 2021
5.1.0 automation moved this from Review In Progress to Done Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
android Relating to the android part of the library bug A defect in the library cloud Relating to Java-SE / Java-EE Cloud Apps
Projects
No open projects
5.1.0
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bilal-alsharifi @RHenigan