Auto-slice STLs in queue #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…automation; also anticipate FILE_ADDED changes upstream
This was referenced Dec 8, 2022
…fixed slicer output path in tmp folder
smartin015
added a commit
that referenced
this pull request
Mar 8, 2023
* Suppress core OctoPrint GCODE scripts when running CPQ scripts of our own * Also protect the patchComms() function from exceptions e.g. due to OctoPrint refactors * Also return original script values in passthru * Configurable GCODE override in print files * Properly order sets by rank * Preprocessor simulator and preview (#194) * Partial commit - extended CustomEvents to include sim stuff, added sim api endpoint, split out settings JS into a separate _event.js file * Fixed simulation execution events, added styling, plus modifiable symtable and display of mutations * Pluralize simulation summary, separate asteval code into automation.py from storage/queries.py, set up tests * Fix tests * Add tests for CPSettingsEvent * Make simulator UI more friendly/helpful and well formatted * Remove todo lines * Tighten spoolmanager integration (#195) * Tighten spoolmanager integration, including validation checks and print-start adjustments * Add tests, improve set_status behavior, add spoolmanager.py files * Fix tests, eliminate stack overflow * Increase idle timeout seconds * Add preprocessor basics to docs (#196) * Add S3D processor (#197) * Compute stats for whole queues (#198) * Extract stats calculations from continuousprint_jobs.js, make also usable on whole queues * Add HTML for viewing queue rollups, make selectively visible * Fix tests, fix batch selection, auto-hide mass estimates when zero * Auto-slice STLs in queue (#166) * First attempt at integrating OctoPrint configured slicers into queue automation; also anticipate FILE_ADDED changes upstream * Added auto-slicing docs and fixed small bug in octoprint version detection * Add working auto-slicer implementation; unit tests TBD * Fix tests * Add driver test * Add tests for slicer profiles in JS, remove extra debug logging * Remove unused driver state, improve verbosity of slicing errors, and fixed slicer output path in tmp folder * Get working enough to verify STL and gcode handled correctly, plus update docs * Fix tests, remove octoprint version req thing and reduce DB noise in testing * Cleanup * 2.4.0rc1 * Creality Ender 3 S1 Pro added (#207) * Ender 3 S1 Pro bed cleaning (#208) * Update gcode_scripts.yaml * Update gcode_scripts.yaml * Add safety temp directory creation, fixed YAML data files * Appease linter * Fix tests and broken links --------- Co-authored-by: UdDReX <44963788+UdDReX@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR targets #147 by repeating the
.resolve()method implemented by LANSetView instances to regular Set instances. In both cases, this is called to resolve any indirection in the set's path into a .gcode file before beginning a print.When
resolve()detects a path ending in.stl, it fails with a named exception that is caught by the ScriptRunner instance. The runner then looks for and invokes a slicer to produce a runnable .gcode file, before starting the print.This also required changes to the Driver state machine to wait on a callback if the slicer needed to be invoked.
Also anticipate FILE_ADDED changes upstream, to close out #107 once OctoPrint/OctoPrint#4687 is landed.
Remaining work:
blah.stl.gcodecomparing to resolved SetView is WAI.stl.gcodesuffix1.9.0Future: