Merge 429e12b into b70bc73

smartinez87 · Jan 20, 2019 · c2a8e73 · c2a8e73
2 parents b70bc73 + 429e12b
commit c2a8e73
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/lib/exception_notifier/slack_notifier.rb b/lib/exception_notifier/slack_notifier.rb
@@ -45,7 +45,8 @@ def call(exception, options={})
       fields.push({ title: 'Hostname', value: Socket.gethostname })
 
       if exception.backtrace
-        formatted_backtrace = "```#{exception.backtrace.first(@backtrace_lines).join("\n")}```"
+        backtrace = clean_backtrace(exception)
+        formatted_backtrace = "```#{backtrace.first(@backtrace_lines).join("\n")}```"
         fields.push({ title: 'Backtrace', value: formatted_backtrace })
       end
 

diff --git a/test/exception_notifier/slack_notifier_test.rb b/test/exception_notifier/slack_notifier_test.rb
@@ -7,6 +7,7 @@ def setup
     @exception = fake_exception
     @exception.stubs(:backtrace).returns(fake_backtrace)
     @exception.stubs(:message).returns('exception message')
+    ExceptionNotifier::SlackNotifier.any_instance.stubs(:clean_backtrace).returns(fake_cleaned_backtrace)
     Socket.stubs(:gethostname).returns('example.com')
   end
 
@@ -195,6 +196,10 @@ def fake_backtrace
     ]
   end
 
+  def fake_cleaned_backtrace
+    fake_backtrace[2..-1]
+  end
+
   def fake_notification(exception = @exception, notification_options = {}, data_string = nil, expected_backtrace_lines = 10, additional_fields = [])
     exception_name = "*#{exception.class.to_s =~ /^[aeiou]/i ? 'An' : 'A'}* `#{exception.class.to_s}`"
     if notification_options[:env].nil?
@@ -214,7 +219,7 @@ def fake_notification(exception = @exception, notification_options = {}, data_st
     fields = [ { title: 'Exception', value: exception.message} ]
     fields.push({ title: 'Hostname', value: 'example.com' })
     if exception.backtrace
-      formatted_backtrace = "```#{exception.backtrace.first(expected_backtrace_lines).join("\n")}```"
+      formatted_backtrace = "```#{fake_cleaned_backtrace.first(expected_backtrace_lines).join("\n")}```"
       fields.push({ title: 'Backtrace', value: formatted_backtrace })
     end
     fields.push({ title: 'Data', value: "```#{data_string}```" }) if data_string