Use backtrace cleaner for Slack notifications #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomier
force-pushed
the
clean_backtrace_slack
branch
from
429e12b
to
6cfb05b
Compare
|
Everything looks good now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #299, the backtrace formatting for Slack notifications was refactored. However, the use of the
BacktraceCleanerhas been forgotten in the transition. Slack notifications are currently using the raw backtrace, making them quite unreadable when the error is raised by a library:This PR restores the use of the backtrace cleaner for Slack notifications, the same way it's done in other Notifiers.
Tests for Slack notifications have been updated to reflect this change.