Restore controller action hash separator #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The removal of the separator was introduced in 9e77440. I believe this to be a regression, as do others in the Pull Request comments [1]. Given the commit message, it doesn't appear that the author appreciated the reasons behind the double hash. Other specs assert that the controller and action name is separated by a hash, not a space: $ grep -r "home#index" test test/exception_notifier/email_notifier_test.rb: assert_equal '[Dummy ERROR] home#index (ZeroDivisionError) "divided by 0"', @mail.subject test/exception_notifier/email_notifier_test.rb: A ZeroDivisionError occurred in home#index: test/exception_notifier/modules/formatter_test.rb: assert_equal 'A *RuntimeError* occurred in *home#index*.', formatter.subtitle test/exception_notifier/modules/formatter_test.rb: assert_equal 'home#index', formatter.controller_and_action $ grep -Er "#\{kontroller.controller_name\}##\{kontroller.action_name\}" test test/exception_notifier/slack_notifier_test.rb: text += " *was processed by* `#{kontroller.controller_name}##{kontroller.action_name}`" if kontroller The test for EmailNotifier was introduced nearly 2 years later in eb17362, so the regression was not caught at the time. The test author mirrored the incorrect behaviour, presumably to get some improved level of coverage based on the existing code. [1] smartinez87#398
|
thanks @garethrees for the contribution! |
|
You're very welcome! 🙏 |
|
Any chance of a gem release to include this fix? 🍰 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removal of the separator was introduced in 9e77440.
I believe this to be a regression, as do others in the Pull Request
comments [1].
Given the commit message, it doesn't appear that the author appreciated
the reasons behind the double hash.
Other specs assert that the controller and action name is separated by a
hash, not a space:
The test for EmailNotifier was introduced nearly 2 years later in
eb17362, so the regression was not caught at the time. The test author
mirrored the incorrect behaviour, presumably to get some improved level
of coverage based on the existing code.
[1] #398