Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs in the README #1

Closed
mcollina opened this issue Aug 3, 2018 · 5 comments
Closed

Docs in the README #1

mcollina opened this issue Aug 3, 2018 · 5 comments

Comments

@mcollina
Copy link

mcollina commented Aug 3, 2018

Can you add some docs in the README? It's not really clear how to use this.

@smartiniOnGitHub
Copy link
Owner

Hi, yes sure I'll add ASAP; the problem is that current features (that I need to better describe in a CHANGELOG) are to create CloudEvent instances and check/validate them (there are some examples in unit tests but I agree that I need to improve).
Next feature is serialize in JSON (I'm still thinking at a good way to do it, because the data part could be encoded at the same time in different formats), so I'll add more info ASAP.
Thanks for now,
Sandro

@smartiniOnGitHub
Copy link
Owner

@mcollina Hi Matteo, I should be able to publish first release in a few days now ... do you think updated example (in the README and now even in a Node.js script in a dedicated 'example' folder) could be good enough to describe simple usage of this library ?
Maybe I could remove some assertions from the README, what do you think ?
I just added even a link to published API documentation (it will be updated soon too).

@mcollina
Copy link
Author

This is not really clear, the example needs to be cleared up, and I would add some more API docs.

One note: it's better to use option objects instead of positional arguments.

@smartiniOnGitHub
Copy link
Owner

Ok, I'll do more cleanup ... but on the more API docs currently there isn't so much exposed by CloudEvent class so can't show more, but of course if you have some idea tell me, I'll be happy to improve it :-) .
On the option argument I tried to use that new ES6 syntax to simplify management of argument default values (to have all the implementation compliant to latest ES features in any place, but still compatible with Node.js 8.11.x), does it make sense ?

@smartiniOnGitHub
Copy link
Owner

More info/cleanup in the README (and no more exclude the 'example' folder in the npm package), and first release (0.1.0) just published, I hope things are a little more clear now.
Be free to reopen if/when needed.
Thanks for now, Sandro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants