cleanup phpdoc #18
Merged
cleanup phpdoc #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| use Handlebars\Cache; | |||
| use Predis\Client as Predis; | |||
| use Redis; | |||
There was a problem hiding this comment.
oh well. phpunit reveils i did not think enough. what about RedisClient and PredisClient?
There was a problem hiding this comment.
You have to remove that, since we cannot rely on the user having the phpredis extension installed.
| */ | ||
| public function __construct($redisClient, LoggerInterface $logger = null, $keyPrefix = self::KEY_PREFIX_DEFAULT) | ||
| { | ||
| if (!$redisClient instanceof Predis && !(class_exists('Redis') && $redisClient instanceof \Redis)) { | ||
| if (!$redisClient instanceof PredisClient && !$redisClient instanceof RedisClient) { |
There was a problem hiding this comment.
this was overcomplicated. instanceof for a not existing class is not a problem in php, see https://3v4l.org/OG7tG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
you missed one occurrence of
Client. i propose we alsouse Redisto not have the absolute name\Redis.