Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added eslint support #27

Merged
merged 2 commits into from
Feb 16, 2017
Merged

Added eslint support #27

merged 2 commits into from
Feb 16, 2017

Conversation

sadasant
Copy link
Contributor

No description provided.

@sadasant sadasant force-pushed the feature/eslint branch 7 times, most recently from 19345d7 to 78de0ee Compare February 16, 2017 20:10
This fixes an eslint error intentionally left to verify that a PR failed
if the files changed are not consistent with the existing eslint rules.
@sadasant sadasant changed the title [WIP] Added eslint support Added eslint support Feb 16, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.029% when pulling 86d2cb2 on feature/eslint into 768e4dd on master.

@sadasant
Copy link
Contributor Author

sadasant commented Feb 16, 2017

Proof that it fails if the changed files have eslint errors: https://travis-ci.org/smartprocure/futil-js/builds/202384532

You can try yourself individual pieces of the code to see the diff files. For example, the following line will show you the files changed from master in your current branch.

LIST=$(git diff-index --name-only origin/master | grep .*\\.js | grep -v json | grep -v eslint | tr '\n' ' '); echo $LIST

@daedalus28 daedalus28 merged commit 95c3b81 into master Feb 16, 2017
@daedalus28 daedalus28 deleted the feature/eslint branch February 16, 2017 20:28
@daedalus28 daedalus28 restored the feature/eslint branch February 16, 2017 20:28
@daedalus28 daedalus28 deleted the feature/eslint branch February 16, 2017 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants