Upgrade Dependency for Issue Found #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
positiveVibes4all
commented
Sep 16, 2022
positiveVibes4all
commented
- Library upgrade to fix dark tooltips that are very hard to read.
- Due to some more tweaks needed on mobile this is being issued as a separate PR.
- Library upgrade to fix dark tooltips that are very hard to read. - Due to some more tweaks needed on mobile this is being issued as a separate PR.
positiveVibes4all
requested review from
daedalus28,
dubiousdavid,
rudolph9 and
stellarhoof
- Conflict in auto-update of libraries found in regard to webpack and karma-webpack libraries. - Ignoring yarn lock files as NPM is currently used, and versioning package-lock files for NPM to solve this problem.
- Pushed version and added change log update.
daedalus28
approved these changes
Sep 20, 2022
stellarhoof
reviewed
Sep 25, 2022
| @@ -40,7 +40,7 @@ jspm_packages | |||
| lib | |||
|
|
|||
| # Package lock files | |||
| package-lock.json | |||
| yarn.lock | |||
There was a problem hiding this comment.
Currently this repo uses NPM and this PR actually started tracking package-lock due to some auto upgrade issues that were happening. When we start using yarn, the exception for it should be removed to properly track the file though to your point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.