-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flowAsync
#411
Merged
Merged
flowAsync
#411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 24, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long overdue.
flowAsync
is magical. You can mix and match sync and async, automatically getPromise.all
andpromiseProps
for arrays and objects, and it'll stay sync if nothing is async (e.g. you don't need to await if nothing is async).flowAsyncDeep
is even more magical. It uses the newresolveOnTree
method to resolve deep tree structures, so it will work even if you're doing really deep promises (e.g. using an async iteratee in_.update
deep in your structure). It's a separate method because traversing the entire object graph is a performance tradeoff we think is worth surfacing to end users. It's possible that we'll deprecate it and make it the default behavior forflowAsync
in a future release if the performance hit is generally not noticeable.flowAsync
andpromiseProps
flowAsyncDeep
andresolveOnTree
writeTreeNode
(default writeNode for tree maps) and rename interally from writeProperty to writeTreeNodeResolves #400 and #107