Handle errors raised when writing trace dumps #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhunleth
approved these changes
Mar 20, 2023
There is a bug in writing trace dumps when a command in the trace buffer is not a Z/IP Packet encapsulated command. It's unclear what command(s) are involved as the issue seems somewhat rare. Until we can pin down the issue, this should prevent trace dumps from crashing under the described circumstances and provide debugging information for a future fix.
bjyoungblood
force-pushed
the
trace-dump-error-handling
branch
from
6ea8a38
to
35212bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in writing trace dumps when a command in the trace buffer
is not a Z/IP Packet encapsulated command. It's unclear what command(s)
are involved as the issue seems somewhat rare.
Until we can pin down the issue, this should prevent trace dumps from
crashing under the described circumstances and provide debugging
information for a future fix.