Outgoing Z/IP Packets ignore install and maintenance header extension #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no reason to send this header extension to Z/IP Gateway even if it is specified (usually this happens because header extensions were copied from an incoming Z/IP Packet).
jjcarstens
approved these changes
Sep 26, 2023
bjyoungblood
added a commit
that referenced
this pull request
Nov 2, 2023
The fix in #843 did not work because the header is `:installation_and_maintenance_report`, not `:install_and_maintenance_report` (copy/pasted from the typespec, which was wrong to begin with).
bjyoungblood
added a commit
that referenced
this pull request
Nov 2, 2023
The fix in #843 did not work because the header is `:installation_and_maintenance_report`, not `:install_and_maintenance_report` (copy/pasted from the typespec, which was wrong to begin with). This also updates `:install_and_maintenance_get` to match.
bjyoungblood
added a commit
that referenced
this pull request
Nov 6, 2023
The fix in #843 did not work because the header is `:installation_and_maintenance_report`, not `:install_and_maintenance_report` (copy/pasted from the typespec, which was wrong to begin with).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no reason to send this header extension to Z/IP Gateway even if
it is specified (usually this happens because header extensions were
copied from an incoming Z/IP Packet).