Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove any() from type send_command_response #873

Merged
merged 1 commit into from Dec 7, 2023
Merged

Remove any() from type send_command_response #873

merged 1 commit into from Dec 7, 2023

Conversation

jfcloutier
Copy link
Contributor

No description provided.

fhunleth
fhunleth reviewed Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@fhunleth fhunleth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve out of hope that this can be true.

bjyoungblood
bjyoungblood approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@bjyoungblood bjyoungblood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is probably true.

@bjyoungblood bjyoungblood merged commit 6edc930 into main Dec 7, 2023
1 check passed
@bjyoungblood bjyoungblood deleted the send_command_response_no_any branch December 7, 2023 00:06
@bjyoungblood bjyoungblood added the bug Something isn't working label Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhunleth fhunleth fhunleth approved these changes

@bjyoungblood bjyoungblood bjyoungblood approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jfcloutier @fhunleth @bjyoungblood