Ignore extra trailing bytes when decoding ThermostatSetpointReport #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfcloutier
force-pushed
the
decode_tstat_setpoint_report_extra
branch
from
34c2e3e
to
5cfba5b
Compare
|
@jfcloutier Could you add a unit test with the response from the Airzone that caused this? |
jfcloutier
force-pushed
the
decode_tstat_setpoint_report_extra
branch
from
5cfba5b
to
54b2b7e
Compare
Test added. |
jfcloutier
force-pushed
the
decode_tstat_setpoint_report_extra
branch
from
54b2b7e
to
8afb65e
Compare
A trailing 0 is sent by the Aidoo Airzone which must be ignored to avoid a parameter decoding failure. [SRH-1012]
jfcloutier
force-pushed
the
decode_tstat_setpoint_report_extra
branch
from
8afb65e
to
f4a77bf
Compare
fhunleth
approved these changes
Feb 7, 2024
bjyoungblood
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A trailing 0 is sent by the Aidoo Airzone which must be ignored to avoid a parameter decoding failure.
SRH-1012