Virtual devices have statically assigned IDs #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Virtual device IDs are currently unstable, as they are assigned as the
count of existing virtual devices + 1. This will also cause major issues
if a virtual device process ever crashes, as it will not be able to be
reregistered without restarting all virtual devices in the process tree.
Instead, IDs should be assigned by the API consumer at the time of
registration. This will assure that `{:virtual, 1}` doesn't switch
implementations with `{:virtual, 2}` because of a change in their
startup order.
**Breaking change**
fhunleth
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Virtual device IDs are currently unstable, as they are assigned as the
count of existing virtual devices + 1. This will also cause major issues
if a virtual device process ever crashes, as it will not be able to be
reregistered without restarting all virtual devices in the process tree.
Instead, IDs should be assigned by the API consumer at the time of
registration. This will assure that
{:virtual, 1}doesn't switchimplementations with
{:virtual, 2}because of a change in theirstartup order.
Breaking change