Add protection from testing against mismatch versions #23
Conversation
Just a convenience for test. It adds the ability to look for a `<tzpath>/version` file. This can then be used to compare your expected TZversion. In our case, we make sure our version matches `Tz.iana_version` since that is considered the source of truth in our tests
| @doc """ | ||
| Return the time zone database version | ||
|
|
||
| This attempts to read `<tzpath>/version` and returns `:unknown` if non-existent. |
There was a problem hiding this comment.
I think this will normally return :unknown since the file version doesn't exist normally. The place that you copied above is only for unit tests.
I've never found any consistency for finding the database version. On MacOS, there's a file called +VERSION that has it. On Ubuntu, the tzdata.zi file lists it as a comment.
There was a problem hiding this comment.
Rereading your comments, I'm not sure if you intended this to be only for unit tests. If so, how about moving this function out of the public API?
|
Closing since the zic version and database are both part of the download from IANA, so they should be the same. The instances that I've seen where there's been a mismatch have been due to stale |
Just a convenience for test. It adds the ability to look for a
<tzpath>/versionfile. This can then be used to compare your expected TZversion.In our case, we make sure our version matches
Tz.iana_versionsince that is considered the source of truth in our tests