-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timescale parity #374
Timescale parity #374
Conversation
…work w/ timescale too.
…rk with timescale.
…e it doesnt work w/ timescale and possibly many other dbs out there. the table creation check can be safely skipped since it has basically no impact on performance---table is only created once!
@chicco785 so I've put together basically everything we need for Timescale as a backend in this PR, instead of splitting query support and all the rest (insert/formatting/other tweaks) in two separate PRs since it turned out to be less work this way. But there are still a few things I haven't got around to doing yet:
|
@c0c0n3 any reason to keep it draft? |
still working on it, would like to sort out the reporter tests...i.e. last point in the task list above |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR makes all QL API endpoints work with Timescale as a backend. From now on, we should be able to use either backend (Crate or Timescale) to store, query and delete NGSI entity data. We can even use both backends at the same time, routing requests to either DB depending on tenant. But notice there still are some differences between the two:
Notice this PR implements new modules and functions to fully support geo queries targeting Timescale---see changes in
geocoding
andsql
packages as well as thetimescale_geo_query
module in thetranslators
package. This PR also implements a number of fixes, tweaks and additions to make the existing translator modules work smoothly with both backends on inserting data and formatting query result sets into JSON---see changes in thetranslators
package.