Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #404 #405

Merged
merged 1 commit into from
Dec 8, 2020
Merged

fix #404 #405

merged 1 commit into from
Dec 8, 2020

Conversation

chicco785
Copy link
Contributor

@chicco785 chicco785 commented Dec 1, 2020

Proposed changes

see #404

Types of changes

What types of changes does your code introduce to the project: Put
an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to
ask. We're here to help! This is simply a reminder of what we are going
to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • I have added tests that prove my fix is effective or that my
    feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in
    downstream modules

Further comments

separated default_backend computation logic for easy reusage

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2020

CLA Assistant Lite bot All contributors have signed the CLA ✍️

@chicco785 chicco785 requested a review from c0c0n3 December 2, 2020 09:52
@c0c0n3
Copy link
Member

c0c0n3 commented Dec 3, 2020

good stuff!!

c0c0n3
c0c0n3 previously approved these changes Dec 3, 2020
* fix #404
@c0c0n3 c0c0n3 merged commit f21d061 into master Dec 8, 2020
@c0c0n3 c0c0n3 deleted the fix-404 branch December 8, 2020 10:47
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants