Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add clarifications to docs in relation to #418 #420

Merged
merged 2 commits into from
Jan 22, 2021
Merged

Conversation

chicco785
Copy link
Contributor

Proposed changes

Provide some background information on data availability after write

Types of changes

What types of changes does your code introduce to the project: Put
an x in the boxes that apply

  • Documentation improvement

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • I have added tests that prove my fix is effective or that my
    feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in
    downstream modules

Further comments

N/A

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️

to create temporal records for them. In general, the whole FIWARE stack, being
based on a micro-service architecture, cannot be regarded as real time
in case you have requirements on guaranteed delivery in a given amount of time.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also add a para along the lines of the following, just to make sure people out there don't interpret our clarification as advice not to use FiWare because of poor performance:

However, even though hard real time may not be FIWARE's forte, in our experience a properly tuned FIWARE stack can perform extremely well and handle very demanding IoT workloads without a glitch.

I've also added a comment to #418 along these lines just to make sure it's crystal clear what we're talking about here is a corner case (hard real time) whereas in the majority of cases FIWARE provides all the performance you'll ever need :-)

@c0c0n3
Copy link
Member

c0c0n3 commented Jan 21, 2021

@chicco785 excellent work! I'd only add one more thing---see my review comment. I think it's already very clear the way you put it, I'm just being paranoid I suppose...

c0c0n3
c0c0n3 previously approved these changes Jan 21, 2021
Copy link
Member

@c0c0n3 c0c0n3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job, thanks a stack!!

@c0c0n3
Copy link
Member

c0c0n3 commented Jan 21, 2021

@chicco785: looks like our travis env isn't happy but that's got nothing to do w/ your PR, is that okay w/ you if i go ahead and merge?

@chicco785
Copy link
Contributor Author

apparent

@chicco785: looks like our travis env isn't happy but that's got nothing to do w/ your PR, is that okay w/ you if i go ahead and merge?

apparently something changed in docker hub, i am trying to fix the problem here: #421

@c0c0n3
Copy link
Member

c0c0n3 commented Jan 21, 2021

cool, let's merge #421 first then, so we can have a clean merge here too. thanks!!

provide some background information on data availability after write
@c0c0n3 c0c0n3 merged commit 02ad413 into master Jan 22, 2021
@c0c0n3 c0c0n3 deleted the update-faq-418 branch January 22, 2021 09:22
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants