Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up to start v0.9 dev #431

Merged
merged 12 commits into from
Feb 2, 2021
Merged

clean up to start v0.9 dev #431

merged 12 commits into from
Feb 2, 2021

Conversation

chicco785
Copy link
Contributor

@chicco785 chicco785 commented Jan 28, 2021

Proposed changes

Types of changes

What types of changes does your code introduce to the project: Put
an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to
ask. We're here to help! This is simply a reminder of what we are going
to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • I have added tests that prove my fix is effective or that my
    feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in
    downstream modules

Further comments

N/A

@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️

@chicco785 chicco785 changed the title clean up to start v0.9 dev wip: clean up to start v0.9 dev Feb 1, 2021
@chicco785 chicco785 changed the title wip: clean up to start v0.9 dev clean up to start v0.9 dev Feb 1, 2021
@chicco785 chicco785 requested a review from c0c0n3 February 1, 2021 20:01
@@ -196,8 +196,6 @@ REST API を介したデータのクエリと取得が計画されています
"Grafana Home"
[grafana.pg]: http://docs.grafana.org/features/datasources/postgres/
"Grafana PostgreSQL Data Source"
[influx]: https://docs.influxdata.com/influxdb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we leave this to @fisuda? not sure if he also mentioned influx db in the japanese docs?

@c0c0n3
Copy link
Member

c0c0n3 commented Feb 2, 2021

@chicco785 good stuff!! I only have one question about the Japanese docs, see my comment above.

@chicco785 chicco785 merged commit 45aff7a into master Feb 2, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2021
@chicco785 chicco785 deleted the prepare-v0.9 branch February 2, 2021 15:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants