feat: Support setting labels and annotations for the CP Service #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #35 +/- ##
==========================================
+ Coverage 39.68% 39.95% +0.26%
==========================================
Files 3 3
Lines 451 453 +2
==========================================
+ Hits 179 181 +2
Misses 241 241
Partials 31 31
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fengye87
reviewed
Apr 4, 2023
api/v1beta1/virtinkcluster_types.go
Outdated
| @@ -22,6 +22,9 @@ type VirtinkClusterSpec struct { | |||
| // of type ClusterIP, which will make workload cluster only accessible within the same cluster. | |||
| ControlPlaneServiceType *corev1.ServiceType `json:"controlPlaneServiceType,omitempty"` | |||
|
|
|||
| // ControlPlaneServiceAnnotations will be appended to the control plane service annotations. | |||
There was a problem hiding this comment.
Maybe we should consider the possibility to let user create the service and we simply use it (or at most add labels to it)? For now we may be dealing with annotations, and someday we may find ourselves dealing with more fields of service. It could be cumbersome then.
There was a problem hiding this comment.
That's a good idea! I'm trying to make it come true.
carezkh
force-pushed
the
care-dev-service-annotations
branch
from
8739239
to
0cd4acc
Compare
carezkh
changed the title
carezkh
force-pushed
the
care-dev-service-annotations
branch
from
0cd4acc
to
0aa58f9
Compare
fengye87
reviewed
Apr 10, 2023
carezkh
force-pushed
the
care-dev-service-annotations
branch
from
0aa58f9
to
1ca6ed5
Compare
carezkh
changed the title
carezkh
force-pushed
the
care-dev-service-annotations
branch
4 times, most recently
from
6b9a0e3
to
a953e54
Compare
carezkh
changed the title
carezkh
force-pushed
the
care-dev-service-annotations
branch
from
a953e54
to
1c0d502
Compare
fengye87
reviewed
Apr 13, 2023
docs/external-cluster.md
Outdated
| @@ -63,6 +63,8 @@ SA_TOKEN="$(kubectl get secret "${SA_SECRET}" -o jsonpath='{.data.token}' | base | |||
| kubectl config --kubeconfig virtink-infra-cluster.kubeconfig set-credentials kubernetes-admin "--token=${SA_TOKEN}" | |||
| ``` | |||
|
|
|||
| >**Note**: In more recent K8S versions, including v1.24, the long term API token will not be automatically created for the ServiceAccount, you may [manually create a token Secret for the ServiceAccount](https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/#manually-create-a-long-lived-api-token-for-a-serviceaccount), and set the enviroment variable `SA_SECRET` above. | |||
There was a problem hiding this comment.
Add a space between > and **. And "in more recent K8s versions" sounds weird
carezkh
force-pushed
the
care-dev-service-annotations
branch
from
1c0d502
to
a74a0ce
Compare
fengye87
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.