feat: Support using external infra cluster #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carezkh
force-pushed
the
care-dev-support-external-cluster
branch
from
bf83b08
to
a817ebe
Compare
fengye87
requested changes
Jun 28, 2022
carezkh
force-pushed
the
care-dev-support-external-cluster
branch
from
a817ebe
to
fc10090
Compare
fengye87
requested changes
Jul 1, 2022
| vm.Spec.Instance.Disks = append(vm.Spec.Instance.Disks, virtv1alpha1.Disk{ | ||
| Name: "cloud-init", | ||
| }) | ||
| vm.Spec.Volumes = append(vm.Spec.Volumes, virtv1alpha1.Volume{ | ||
| Name: "cloud-init", | ||
| VolumeSource: virtv1alpha1.VolumeSource{ | ||
| CloudInit: &virtv1alpha1.CloudInitVolumeSource{ | ||
| UserDataSecretName: *ownerMachine.Spec.Bootstrap.DataSecretName, | ||
| UserData: string(secret.Data["value"]), |
There was a problem hiding this comment.
Maybe it's better we base64 encode it?
fengye87
changed the title
carezkh
force-pushed
the
care-dev-support-external-cluster
branch
from
7e0b7bc
to
46f7987
Compare
fengye87
approved these changes
Jul 1, 2022
fengye87
requested changes
Jul 4, 2022
| @@ -67,65 +71,136 @@ func (r *VirtinkClusterReconciler) Reconcile(ctx context.Context, req ctrl.Reque | |||
| } | |||
|
|
|||
| func (r *VirtinkClusterReconciler) reconcile(ctx context.Context, cluster *infrastructurev1beta1.VirtinkCluster) error { | |||
| if !cluster.DeletionTimestamp.IsZero() { | |||
| if !controllerutil.ContainsFinalizer(cluster, finalizer) { | |||
There was a problem hiding this comment.
We should only add finalizer when object is not deleted. See https://book.kubebuilder.io/reference/using-finalizers.html
| @@ -67,7 +69,8 @@ func (r *VirtinkMachineReconciler) Reconcile(ctx context.Context, req ctrl.Reque | |||
| } | |||
|
|
|||
| func (r *VirtinkMachineReconciler) reconcile(ctx context.Context, machine *infrastructurev1beta1.VirtinkMachine) error { | |||
| if !machine.DeletionTimestamp.IsZero() { | |||
| if !controllerutil.ContainsFinalizer(machine, finalizer) { | |||
| controllerutil.AddFinalizer(machine, finalizer) | |||
There was a problem hiding this comment.
Same here, see https://book.kubebuilder.io/reference/using-finalizers.html
carezkh
force-pushed
the
care-dev-support-external-cluster
branch
from
46f7987
to
c4ee1b1
Compare
fengye87
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to use external cluster for infrastructure
kubectl create secret generic <secret-name> --from-file=kubeconfig=<kubeconfig-file-path>VirtinkCluster.Spec.InfraClusterSecretRef. When nil, the management cluster will be used for infrastructure.VirtinkCluster.Spec.ConrolPlaneServiceTypetoLoadBalancer. You can set this filed toNodePortorLoadBalancer(nil for NodePort). When using external cluster,LoadBalanceris required and its external IP should be reachable in management cluster.