feat: Live migration #29
Conversation
Codecov Report
@@ Coverage Diff @@
## main #29 +/- ##
==========================================
- Coverage 35.72% 31.13% -4.59%
==========================================
Files 3 5 +2
Lines 949 1275 +326
==========================================
+ Hits 339 397 +58
- Misses 560 818 +258
- Partials 50 60 +10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
scuzhanglei
force-pushed
the
live-migration
branch
3 times, most recently
from
ffcc138
to
60822eb
Compare
pkg/daemon/vm_controller.go
Outdated
| } | ||
| case virtv1alpha1.VirtualMachineMigrationSent: | ||
| if vm.Status.Migration.TargetNodeName == r.NodeName { | ||
| // TODO handle VmNotCreated error |
There was a problem hiding this comment.
we don't know the VM is creating or it will never be created(maybe something wrong). raise the error might be a better choice now.
and now we just raise an error during VM is migrating instead of return a ctrl.Result with requeue. maybe we need another PR to fix all these questions.
There was a problem hiding this comment.
We can capture certain type of errors in the main reconcile func and convert it to a requeue. But yeah, it can be another commit
scuzhanglei
force-pushed
the
live-migration
branch
2 times, most recently
from
37875ee
to
93e4c72
Compare
| Recorder record.EventRecorder | ||
| } | ||
|
|
||
| // +kubebuilder:rbac:groups=virt.virtink.smartx.com,resources=virtualmachinemigrations,verbs=get;list;watch |
There was a problem hiding this comment.
the controller doesn't need create/update/delete VMM. keep the permissions less.
scuzhanglei
force-pushed
the
live-migration
branch
from
93e4c72
to
8e9aead
Compare
No description provided.