Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use cloud-hypervisor API to start VM #63

Closed
wants to merge 1 commit into from
Closed

feat: Use cloud-hypervisor API to start VM #63

wants to merge 1 commit into from

Conversation

scuzhanglei
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 24, 2022 •
edited
Loading

Codecov Report

Merging #63 (6bb864a) into main (6bb864a) will not change coverage.
The diff coverage is n/a.

❗ Current head 6bb864a differs from pull request most recent head eecf902. Consider uploading reports for the commit eecf902 to get more accurate results

@@           Coverage Diff           @@
##             main      #63   +/-   ##
=======================================
  Coverage   36.04%   36.04%           
=======================================
  Files           5        5           
  Lines        1498     1498           
=======================================
  Hits          540      540           
  Misses        887      887           
  Partials       71       71

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@scuzhanglei
Copy link
Contributor Author

Because this s6-overlay issue, if an error occurred in virt-prerunner, the pod will still be running, instead of being failed. this cause VM hang on scheduled.

fengye87
fengye87 requested changes Oct 26, 2022
View reviewed changes
cmd/virt-prerunner/main.go Show resolved Hide resolved
pkg/controller/vm_controller.go Outdated Show resolved Hide resolved
pkg/daemon/vm_controller.go Show resolved Hide resolved
@scuzhanglei scuzhanglei force-pushed the use-cloud-hypervisor-api-to-start-vm branch 2 times, most recently from a68726c to 29c768a Compare October 26, 2022 09:41
@scuzhanglei
Copy link
Contributor Author

Because this s6-overlay issue, if an error occurred in virt-prerunner, the pod will still be running, instead of being failed. this cause VM hang on scheduled.

this issue has been fixed by adding S6_BEHAVIOUR_IF_STAGE2_FAILS=2 env to the container, it will stop the container if any error occurred in virt-prerunner.

@scuzhanglei scuzhanglei marked this pull request as draft December 1, 2022 07:05
@scuzhanglei scuzhanglei force-pushed the use-cloud-hypervisor-api-to-start-vm branch from 29c768a to eecf902 Compare December 1, 2022 07:08
@scuzhanglei
Copy link
Contributor Author

merged in #73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carezkh carezkh carezkh left review comments

@fengye87 fengye87 Awaiting requested review from fengye87

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@scuzhanglei @fengye87 @carezkh