Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add timeout for calling cloud-hypervisor api #80

Conversation

scuzhanglei
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #80 (6b3dbdc) into main (c5bf44f) will increase coverage by 0.57%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   34.78%   35.35%   +0.57%     
==========================================
  Files           6        6              
  Lines        1912     1912              
==========================================
+ Hits          665      676      +11     
+ Misses       1143     1136       -7     
+ Partials      104      100       -4     
Impacted Files Coverage Δ
pkg/controller/vm_controller.go 23.55% <0.00%> (+1.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fengye87
Copy link
Contributor

fengye87 commented Jan 6, 2023

Will this timeout affect migration API call?

@scuzhanglei scuzhanglei merged commit d7d5162 into smartxworks:main Jan 10, 2023
@scuzhanglei
Copy link
Contributor Author

Will this timeout affect migration API call?

nope, if timeout happened would raise an error to trigger requeue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants