Skip to content
This repository has been archived by the owner on Aug 14, 2018. It is now read-only.

Credentials need to be thread-safe #14

Closed
mholt opened this issue May 22, 2014 · 2 comments
Closed

Credentials need to be thread-safe #14

mholt opened this issue May 22, 2014 · 2 comments
Labels

Comments

@mholt
Copy link
Contributor

mholt commented May 22, 2014

Issue #13 addressed the thread safety of signing requests, but highlighted that now the credentials are potential hazards for race conditions.

@peterbourgon
Copy link

😎

@mholt
Copy link
Contributor Author

mholt commented Jun 2, 2014

@peterbourgon My coworker Dane is working on PR #16 which should fix this. All of the Sign functions become variadic, and will accept their own instance of a Credentials struct to use in addition to a request. If credentials are not provided, then that function will make its own instance using environment variables or the IAM role. There will be no more shared Keys variable.

@mholt mholt closed this as completed Jun 2, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants