Credentials as a parameter to sign.

[daneuriona]

Adding a variadic option to sign calls so that we can provide credentials directly if we like instead of using ENV variables.

[mholt]

Let's make all of these a len check like above

[daneuriona]

b7d78fd shows up in the Pull Request, but the diff still shows the old check.

[peterbourgon]

Am I reading this correctly that you're using variadic function parameters as a sort of poor-man's function overloading?

[daneuriona]

Got rid of global Keys to try and make awsauth reenterant via 3c21e95. If user doesn't specifically pass Credentials they will fall back to env definitions. Not sure about what a rich man's function overloading in Go would look like, I'm new to the language. If there is a better way of going about it, I'd settle for upper middle class. My bad.

[peterbourgon]

Not sure about what a rich man's function overloading in Go would look like . . . If there is a better way of going about it, I'd settle for upper middle class.

func Sign(req *http.Request, creds Credentials) *http.Request {
    // ...
}

func SignFromEnv(req *http.Request) *http.Request {
    return Sign(req, Credentials{
        os.Getenv(...),
        // ...
    })
}

Or, better yet, avoid magic altogether.

func Sign(req *http.Request, creds Credentials) *http.Request {
    // ...
}

func MakeCredentialsFromEnv() (Credentials, error) {
    key := os.Getenv(...)
    if key == "" {
        return Credentials{}, fmt.Errorf("AWSKEY not in env (or whatever)")
    }
    // ...
   return Credentials{key, ...}, nil
}

creds, err := awsauth.MakeCredentialsFromEnv()
if err != nil {
    log.Fatal(err)
}
req = awsauth.Sign(req, creds)

[daneuriona]

So no optional params then. Are variadic params dangerous in some way I'm not realizing? Maybe opening the door to pass huge objects, like buffer overrun or something of that nature?

[peterbourgon]

Variadic parameters are designed for use in e.g. printf-style functions, where some amount of reflection over the parameter list is unavoidable.