Skip to content

Commit

Permalink
strip property must now be public
Browse files Browse the repository at this point in the history
  • Loading branch information
uwetews committed Apr 7, 2015
1 parent a92302d commit 6fb27d5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lexer/smarty_internal_templateparser.y
Expand Up @@ -91,7 +91,7 @@ class Smarty_Internal_Templateparser
*
* @var bool
*/
private $strip = false;
public $strip = false;
/**
* compiler object
*
Expand Down
2 changes: 1 addition & 1 deletion libs/sysplugins/smarty_internal_templateparser.php
Expand Up @@ -157,7 +157,7 @@ class Smarty_Internal_Templateparser
*
* @var bool
*/
private $strip = false;
public $strip = false;
/**
* compiler object
*
Expand Down

3 comments on commit 6fb27d5

@ceased-ebc
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uwetews Hi there, have you got a update on when a smarty version compatible with HHVM fully is available?

Thanks

@uwetews
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can run Smarty with HHVM.

Currently HHVM has one PHP compatibility issue.
See facebook/hhvm#4797 (comment)

For that reason you may see a modified template or cache content with a delay of one page call.

A couple of PHPUnit test will currently fail for same reason.
There is some work in progress to update the PHPUnit test for better HHVM compatibility.

@ceased-ebc
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you / Smarty (who has been developing this fix) offering a install service (set up ) for $$$? so i can be sure it is installed correctly.

Please sign in to comment.