fixed error when using section with nocache.

Fixes #1034
smarty-php · Jun 16, 2024 · 8ecde47 · 8ecde47
1 parent b978cb3
commit 8ecde47
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 2 deletions.
diff --git a/changelog/1034.md b/changelog/1034.md
@@ -0,0 +1 @@
+- Fixed error when using section with nocache [#1034](https://github.com/smarty-php/smarty/issues/1034)
diff --git a/src/Compile/Tag/Section.php b/src/Compile/Tag/Section.php
@@ -99,7 +99,7 @@ public function compile($args, \Smarty\Compiler\Template $compiler, $parameter =
 
 		if ($compiler->tag_nocache) {
 			// push a {nocache} tag onto the stack to prevent caching of this block
-			$this->openTag('nocache');
+			$this->openTag($compiler, 'nocache');
 		}
 
 		$this->openTag($compiler, 'section', ['section', $compiler->tag_nocache]);

diff --git a/src/Compile/Tag/SectionClose.php b/src/Compile/Tag/SectionClose.php
@@ -33,7 +33,7 @@ public function compile($args, \Smarty\Compiler\Template $compiler, $parameter =
 
 		if ($nocache_pushed) {
 			// pop the pushed virtual nocache tag
-			$this->closeTag('nocache');
+			$this->closeTag($compiler, 'nocache');
 		}
 
 		$output = "<?php\n";

diff --git a/tests/UnitTests/TemplateSource/TagTests/Section/CompileSectionTest.php b/tests/UnitTests/TemplateSource/TagTests/Section/CompileSectionTest.php
@@ -148,4 +148,10 @@ public function dataTestElseSpacing()
         );
     }
 
+    public function testSectionWithNocache()
+    {
+        $source = 'string:{section name=module start=0 loop=1 nocache}{/section}';
+        $this->assertEquals('', $this->smarty->fetch($source));
+    }
+
 }