Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version 1.3.31 not compatible with PHP 5.2 #365

Closed
aschleifer opened this issue May 16, 2017 · 2 comments
Closed

version 1.3.31 not compatible with PHP 5.2 #365

aschleifer opened this issue May 16, 2017 · 2 comments

Comments

@aschleifer
Copy link

Hi,

the composer.json for version 1.3.31 states that it is compatible with php >= 5.2 but it uses the __DIR__ constant which was introduced in PHP 5.3 (https://github.com/smarty-php/smarty/blob/v3.1.31/libs/Smarty.class.php#L38)

Either the version should be marked as only 5.3 compatible or should not use PHP 5.3 features.

Best regards
uwetews added a commit that referenced this issue May 21, 2017
@uwetews
- bugfix version 3.1.31 did fail under PHP 5.2
f860f7c 
    #365
@scottchiefbaker
Copy link

Looks like this will be fixed in the next official release. Good work.

@uwetews
Copy link
Contributor

uwetews commented Oct 10, 2017

The fix is in the master branch and will later be included in the 3.1.32 release

@uwetews uwetews closed this as completed Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@uwetews @scottchiefbaker @aschleifer